feat: improve global API ergonomics #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronag
commented
Apr 14, 2021
•
ronag
commented
undici.request('http://foo:800', { path: '/bar' })
undici.request({ path: '/bar', origin: 'http://foo:800' })
undici.request('http://foo:800/bar')
mcollina
requested changes
Apr 14, 2021
dnlup
approved these changes
Apr 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #740 +/- ##
===========================================
- Coverage 100.00% 99.94% -0.06%
===========================================
Files 24 24
Lines 1887 1899 +12
===========================================
+ Hits 1887 1898 +11
- Misses 0 1 +1
Continue to review full report at Codecov.
|
|
This shipped without tests. |
|
Missed pushing tests. Will do so when I’m by computer. |
ronag
added a commit
that referenced
this pull request
Apr 14, 2021
* feat: improve global API ergonomics
undici.request('http://foo:800', { path: '/bar' })
undici.request({ path: '/bar', origin: 'http://foo:800' })
undici.request('http://foo:800/bar')
* fixup
* fixup
* fixup
* fixup
* fixup
* fixup
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* feat: improve global API ergonomics
undici.request('http://foo:800', { path: '/bar' })
undici.request({ path: '/bar', origin: 'http://foo:800' })
undici.request('http://foo:800/bar')
* fixup
* fixup
* fixup
* fixup
* fixup
* fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.