fix: unify connect options

[ronag]

Should be fully backwards compatible.

[ronag]

I had to remove a test as it incorrectly relies on mutating options. Also not sure how that could work at all as the session cache does not key on cipher.

[codecov-commenter]

Codecov Report

Merging #881 (595a609) into main (494201a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #881   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2104      2106    +2     
=========================================
+ Hits          2104      2106    +2     

Impacted Files	Coverage Δ
lib/client.js	100.00% <100.00%> (ø)
lib/core/connect.js	100.00% <100.00%> (ø)
lib/pool.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494201a...595a609. Read the comment docs.

[ronag]

@szmarczak This would allow you to forward a custom lookup function directly to net.connect and tls.connect.

[mcollina]

lgtm

[dnlup]

I am late to this, sorry. Great work!

[NN-Binary]

Great job! Any manual on how to change the options (I need to use a custom lookup function) ?

[ronag]

Great job! Any manual on how to change the options (I need to use a custom lookup function) ?

The connect option will be passed into net.connect so you can just do connect: { lookup }.

[NN-Binary]

I'm not sure how to use it in Dispatch, I've just updated to the latest Undici, how do I add lookup in Dispatch?
Thank you

[ronag]

You don't need to use dispatch. Just pass connect option to Agent constructor. Don't forget you need to run off master since we haven't made a release yet.

[NN-Binary]

Wow, thank you so much for the quick reply.
Right now my code is quite simple:

                var HTTPClient = new Client('http://google.com')
                HTTPClient.dispatch({
                    path: '/',
                    method: 'GET',
                    headers: {
                        // Headers
                    },
                    lookup: CUSTOM_FUNCTION()
                }, {
                    ...
                })

Agent should be placed in the new Client? Sorry

[ronag]

const client = new Client('http://google.com', {
  connect: { lookup: CUSTOM_FUNCTION }
})

const { body, statusCode, headers } = await client.request({
                    path: '/',
                    method: 'GET',
                    headers: {
                        // Headers
                    },
})

[NN-Binary]

Oh! You are amazing. thank you so much @ronag

[NN-Binary]

EDIT: When getting the Master branch, it seems that "Client" doesn't exist anymore.

import { request, Client  } from 'undici';
                  ^^^^^^
SyntaxError: Named export 'Client' not found. The requested module 'undici' is a CommonJS module, which may not support all module.exports as named exports.

npm install git://github.com/nodejs/undici/tree/master --save
No problem here, it fetches Undici but Client Method doesn't exist.

This is the right branch? correct?
Did anything changed between the current version and Master? In term of how I should import it?

From what I'm seeing in index.js, a lot of things changed especially in what is exported or not, is it normal?

Edit: it works if I change my imports to:
import undici from 'undici';

Is it normal that the behavior is different or it's because I don't do it properly?

Well it seems to not work at all anymore, even changing new Client by new undici.Client, I keep getting weird errors
6: 0xd61c66 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/usr/bin/node]

Sorry I'm lost

[RuralDependencies]

EDIT: When getting the Master branch, it seems that "Client" doesn't exist anymore.

import { request, Client  } from 'undici';
                  ^^^^^^
SyntaxError: Named export 'Client' not found. The requested module 'undici' is a CommonJS module, which may not support all module.exports as named exports.

npm install git://github.com/nodejs/undici/tree/master --save
No problem here, it fetches Undici but Client Method doesn't exist.

This is the right branch? correct?
Did anything changed between the current version and Master? In term of how I should import it?

From what I'm seeing in index.js, a lot of things changed especially in what is exported or not, is it normal?

Edit: it works if I change my imports to:
import undici from 'undici';

Is it normal that the behavior is different or it's because I don't do it properly?

Well it seems to not work at all anymore, even changing new Client by new undici.Client, I keep getting weird errors
6: 0xd61c66 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/usr/bin/node]

Sorry I'm lost

The branch that works with the option you are looking for is here:
https://github.com/nodejs/undici/tree/refactor-write

Master seems behind (version 3)

[ronag]

Please open a separate issue.