documentation and test for using client certificates #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #890 +/- ##
==========================================
- Coverage 99.81% 99.62% -0.19%
==========================================
Files 26 26
Lines 2121 2126 +5
==========================================
+ Hits 2117 2118 +1
- Misses 4 8 +4
Continue to review full report at Codecov.
|
ronag
reviewed
Jul 19, 2021
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
approved these changes
Jul 19, 2021
ronag
reviewed
Jul 19, 2021
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
approved these changes
Jul 19, 2021
Closed
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* test: client certificate usage * docs: add best practices section for using client certificates * Update docs/best-practices/client-certificate.md Co-authored-by: Robert Nagy <ronagy@icloud.com> * test: pass connection options through `connect` * Update docs/best-practices/client-certificate.md Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #842 I have added a test and documentation for using client certificate authentication with
undici.Let me know if this is the right direction.