Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add local_build.sh script and instructions for local/dev use #108

Merged
merged 5 commits into from
Jan 20, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 18, 2024

About time this got done, mainly useful for people contributing new recipes, so they can actually test them locally (and we can too).

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend building and running the container(s) with the same uid and gid as the host user otherwise you can end up with mismatched owner/permissions in the mounted volumes after the build(s) completes.

bin/local_build.sh Outdated Show resolved Hide resolved
bin/local_build.sh Show resolved Hide resolved
bin/local_build.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update works great but the variable needs to be passed to the other two docker commands. I was able to successfully local_build my branch after making the changes below

bin/local_build.sh Outdated Show resolved Hide resolved
bin/local_build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

@rvagg rvagg merged commit ee6ebd9 into main Jan 20, 2024
@rvagg rvagg deleted the rvagg/local_build branch January 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants