docs: join instructions in README.md

[wesleytodd]

Added a section about joining. I have not worked before with the ncu-team sync tool mentioned in #2, but this process has worked really well in the package maintenance working group. @MylesBorins is there a good happy medium which would have nice instructions and not require out of band user action?

[MylesBorins]

I added instructions already in GOVERNANCE.md for this. So if you want to move it to the README I think it might make sense to remove the duplicated copy

https://github.com/nodejs/web-server-frameworks/blob/master/GOVERNANCE.md#team-membership

TL;DR make an issue. I highly suggest using ncu-team sync to keep the list up to date rather than doing it manually... as it is p easy to have someone added to the README but not to the org.

[wesleytodd]

I was thinking about this as an alternate to that process. The readme part was just following what was in the package maintenance group readme

Changes to Team membership should be proposed with an issue and labelled web-server-framework-agenda to be included in the next team meeting.

The difference being that I really like the "add my name" commit and just following the normal PR review policy instead of having to discuss or spend time on it in the meetings.

TL;DR make an issue. I highly suggest using ncu-team sync to keep the list up to date rather than doing it manually... as it is p easy to have someone added to the README but not to the org.

I completely agree that we would like the automation, is there a simple way to hook it into a merge GH action? It would be awesome if it just listened for a PR being merged and added them automatically to the team. Does that make sense?

[MylesBorins]

@wesleytodd AFAIK there is no way to automate this without giving a bot Org Ownership. You can totally do the PR thing and make adding the user to the team something that blocks landing the PR.

My experience with the modules team was that the issue thing worked better than a PR. Could use emoji instead of PR review for approvals and apply the same 48 hour window as PR approvals.

Whatever the case I am not a member of this group, so y'all should feel free to do whatever works best for you. There are a couple org owners in the group so you should have no problem getting things updated

[wesleytodd]

Ok, I will add this to the agenda. The reason I opened this fist was just so that if it was easy, anyone new would have a clear direction to onboard themselves. But I would rather get it right than commit to this approach.

[arei]

Should this be changed to reflect the pending changes in the governance doc ala #28 ?

[wesleytodd]

Yeah, I will update based on that. I just commented over there that I would like to get the automation working this weekend. If that is good then we can update these instructions to match.

[ghermeto]

this is PR outdated... can you update the How to Join section to link to the governance doc?

[Ethan-Arrowood]

Bumping this @wesleytodd if you can't get to it let me know and I can complete this PR for ya

[Ethan-Arrowood]

Rebased and updated readme. Rerequesting reviews now 😄

[mhdawson]

LGTM

[Ethan-Arrowood]

I'm going to merge this so I can complete the book keeping before our next meeting