Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMS-93 #542

Merged
merged 6 commits into from Oct 24, 2023
Merged

ZMS-93 #542

merged 6 commits into from Oct 24, 2023

Conversation

NickOvt
Copy link
Contributor

@NickOvt NickOvt commented Oct 20, 2023

  • mailbox-handler.js added createAsync as the rewritten and modern version of original create function.
    support for legacy callback create is still there so no older code breaks.
  • Now there is a hard limit on mailboxes count for a single user: 1500 mailboxes
  • Added new error message (both IMAP error and API error) respectively "OVERQUOTA" and "ReachedMailboxesCountLimit"

@NickOvt NickOvt requested a review from andris9 October 20, 2023 09:22
Copy link
Member

@andris9 andris9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments. In general, seems great 👍

lib/mailbox-handler.js Outdated Show resolved Hide resolved
lib/mailbox-handler.js Outdated Show resolved Hide resolved
lib/mailbox-handler.js Outdated Show resolved Hide resolved
lib/mailbox-handler.js Outdated Show resolved Hide resolved
lib/tools.js Outdated Show resolved Hide resolved
@andris9 andris9 merged commit 779bb11 into master Oct 24, 2023
6 checks passed
@andris9 andris9 deleted the ZMS-93 branch October 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants