Add sigma_delta module. #1000
Merged
Add sigma_delta module. #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks cool! One question: should the pin number checks be turned into a MOD_CHECK(sigmadelta) and abstracted in the platform layer? Just thinking ahead to hopeful ESP32 support... |
|
Thanks for the hint - these literals weren't a portable solution. |
devsaurus
force-pushed
the
sigma_delta
branch
2 times, most recently
from
e29df32
to
eb825fa
Compare
|
It appears that this PR collides with #1023 by now. I'm postponing this one and rebase once the other got merged. |
|
I'll do the extra commit to sweep up all the feedback on #1023 tomorrow and then we should be good to go. |
devsaurus
force-pushed
the
sigma_delta
branch
from
eb825fa
to
8982650
Compare
|
Rebased onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Lua commands to control the "sigma-delta" signal generator described in A first order sigma-delta signal from io pin source.
Documentation is a bit sparse and I had to derive most details with waveform scoping, though I hope that the API doc provides enough information of what to expect:
A hardware-driven pulse generator with 12.5 ns to 3.2 µs high (or low) duration and total period of 2x to 256x. It can be also operated as 8 bit PWM with fixed 312 kHz frequency. Any GPIO except pin 0 / GPIO16 is selectable as output.