Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Honeywell HMC5883L digital compass #1253

Merged
merged 5 commits into from Jun 5, 2016

Conversation

jschmidlapp
Copy link
Contributor

No description provided.

@marcelstoer
Copy link
Member

Can't comment on the C code but on a number of formalities. See https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md#writing-documentation:

  • we appreciate descriptions for PRs
  • modules in user_modules.h should be alphabetically sorted a-z
  • module documentation should be added to mkdocs.yml
  • modules in mkdocs.yml should be alphabetically sorted a-z
  • functions in the module documentation should be alphabetically sorted a-z

uint32_t scl;
uint8_t devid_a, devid_b, devid_c;

if (!lua_isnumber(L, 1) || !lua_isnumber(L, 2)) {
Copy link
Collaborator

@TerryE TerryE Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is redundant so drop it; the check integer calls do this anyway. Also use the arg check macro instead of an if predicate and an error call: less source lines and a better diagnostic for the app programmer.

@jmattsson
Copy link
Member

👍 with similar comments as on #1252.

@marcelstoer marcelstoer merged commit bb9e210 into nodemcu:dev Jun 5, 2016
@marcelstoer marcelstoer added this to the 1.5.4 milestone Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants