Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron fixes #1884

Merged
merged 2 commits into from Mar 27, 2017
Merged

Cron fixes #1884

merged 2 commits into from Mar 27, 2017

Conversation

djphoenix
Copy link
Contributor

Fixes #1878.
Also fixes string-description field order as in docs.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well.
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

marcelstoer
marcelstoer approved these changes Mar 26, 2017
View reviewed changes
Copy link
Member

@marcelstoer marcelstoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a tricky one, well done!

@devsaurus devsaurus merged commit 92cfbb4 into nodemcu:dev Mar 27, 2017
@devsaurus devsaurus added this to the 2.0.0-follow-up milestone Mar 27, 2017
@djphoenix djphoenix deleted the cron-fix branch March 27, 2017 11:07
This was referenced Apr 25, 2017
Closed
Closed
eiselekd pushed a commit to eiselekd/nodemcu-firmware that referenced this pull request Jan 7, 2018
@djphoenix
Cron fixes (nodemcu#1884)
e9d31cc 
* Fix cron values >32

* Fix crontab description items order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstoer marcelstoer marcelstoer approved these changes

@devsaurus devsaurus devsaurus approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djphoenix @marcelstoer @devsaurus