Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions wifi.getcountry() and wifi.setcountry() #2330

Merged
merged 1 commit into from Mar 31, 2018

Conversation

dnc40085
Copy link
Contributor

Adds feature requested in #2312.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

This PR exposes the SDK functions (wifi_set_country() and wifi_get_country()) that were introduced with SDK ver. 2.2.0.

@marcelstoer marcelstoer added this to the 2.2 milestone Mar 30, 2018
Copy link
Member

@devsaurus devsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. I can connect to my test AP with hidden SSID on channel 13 after setting

wifi.setcountry({policy = wifi.COUNTRY_MANUAL})

Thanks a lot @dnc40085 for the quick response!

@marcelstoer
Copy link
Member

Arnim do you think we need to mention this somewhere explicitly (apart from the release notes) or can you merge? I plan to create the master drop on Monday evening.

@devsaurus
Copy link
Member

Without further details from Espressif, #2335 is the best "documentation" approach IMO.
Sorry for yet-another-issue 😕

@devsaurus devsaurus merged commit 9af4f58 into nodemcu:dev Mar 31, 2018
@dnc40085 dnc40085 deleted the dev_add_wifi.country branch May 10, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants