Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for dhcp ntp server (option 42) reloaded #2709

Merged
merged 6 commits into from
Jul 27, 2019

Conversation

HHHartmann
Copy link
Member

@HHHartmann HHHartmann commented Mar 29, 2019

Fixes #2651.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*. (why do I get an old template here with wrong path /en)

support for ntp server offered via dhcp (option 42)

since #2660 is unchanged for over one month I try this one.

I took the changes of #2660 and added some fixes

Tested with DHCP server with and without this feature

app/modules/sntp.c Outdated Show resolved Hide resolved
@marcelstoer marcelstoer added this to the Next release milestone Apr 5, 2019
@marcelstoer
Copy link
Member

Needs to resolve the conflict in sntp.c ("c_stdlib.h" vs <stdlib.h>).

@HHHartmann HHHartmann self-assigned this Jul 25, 2019
app/include/user_version.h Outdated Show resolved Hide resolved
@marcelstoer marcelstoer merged commit 73e6651 into nodemcu:dev Jul 27, 2019
nwf added a commit to nwf/nodemcu-firmware that referenced this pull request Jul 27, 2019
This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
nodemcu#2819 has landed, now
that nodemcu#2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
nwf added a commit to nwf/nodemcu-firmware that referenced this pull request Jul 27, 2019
This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
nodemcu#2819 has landed, now
that nodemcu#2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
marcelstoer pushed a commit that referenced this pull request Dec 9, 2019
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
#2819 has landed, now
that #2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
vsky279 pushed a commit to vsky279/nodemcu-firmware that referenced this pull request Dec 27, 2019
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
nodemcu#2819 has landed, now
that nodemcu#2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
@HHHartmann HHHartmann deleted the dhcp_ntp-server branch May 1, 2020 16:41
marcelstoer pushed a commit that referenced this pull request Jun 9, 2020
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
#2819 has landed, now
that #2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants