Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #3450

Merged
merged 10 commits into from Feb 18, 2024
Merged

docs: update README.md #3450

merged 10 commits into from Feb 18, 2024

Conversation

MichaelCurrin
Copy link
Contributor

@MichaelCurrin MichaelCurrin commented Jul 28, 2021

  • This PR is for the dev branch rather than for the release branch.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).

@MichaelCurrin
Copy link
Contributor Author

I noticed the Travis link goes here

https://travis-ci.org/github/nodemcu/nodemcu-firmware

Which is deprecated

and recommends going here. So I used this

https://travis-ci.com/github/nodemcu/nodemcu-firmware

@marcelstoer
Copy link
Member

Some of those changes are subjective. As for Travis, we should actually remove .travis.yml (as we don't need it anymore) and instead add the shield for our GitHub workflow.

And this really should land on dev instead of release as the template requires.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MichaelCurrin
Copy link
Contributor Author

Thanks. I've removed the more subject changes.

Now it's mostly about making H1s into H2s (accessibility scores such in SEO engines will penalize you will having more than one H1 on a page).

I've replaced with a GH Actions badge.

Sorry I misunderstood how the dev/release bit worked.

README.md Outdated Show resolved Hide resolved
@marcelstoer marcelstoer changed the base branch from release to dev July 31, 2021 21:22
@marcelstoer marcelstoer changed the base branch from dev to release July 31, 2021 21:23
@HHHartmann
Copy link
Member

do we want to also take this PR?
Why is ist against release and not dev?

@HHHartmann HHHartmann mentioned this pull request Feb 18, 2024
@marcelstoer marcelstoer self-requested a review February 18, 2024 09:36
@marcelstoer
Copy link
Member

I'll clean this up and rebase on dev.

@marcelstoer marcelstoer changed the base branch from release to dev February 18, 2024 09:38
@marcelstoer marcelstoer merged commit 68ffcfe into nodemcu:dev Feb 18, 2024
18 checks passed
marcelstoer pushed a commit that referenced this pull request Feb 25, 2024
@MichaelCurrin MichaelCurrin deleted the patch-1 branch March 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants