Skip to content

Commit

Permalink
Revert "Update tag-major.yml (#23)" (#30)
Browse files Browse the repository at this point in the history
This reverts commit 85ab3c3.

GitHub Releases are essentially broken when trying to autogenerate notes
from the most recent tag. (It grabs the vN tag even though it's a
lightweight tag that is not "permanent". Thanks to github's recommended
workflow/actions process.)

Additionally, it messes with local development because tags won't
overwrite by default.
  • Loading branch information
jasonkarns committed Jun 2, 2024
1 parent 865f2a7 commit ea7cbb3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: git push -f origin "HEAD:${GITHUB_REF%%.*}"
- run: git push -f origin "HEAD:refs/heads/${GITHUB_REF_NAME%%.*}"

npm:
permissions: {id-token: write}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tag-major.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: git push -f origin "HEAD:${GITHUB_REF%%.*}"
- run: git push -f origin "HEAD:refs/heads/${GITHUB_REF_NAME%%.*}"

0 comments on commit ea7cbb3

Please sign in to comment.