Generate analytics data from npm downloads #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic Rake extensions: - Extends rake's FileTask to be an IO-readable. (and Pathname-able) - Extracts logic for any task to represent a JSON file (can be included in any IO-readable) - Defines HttpResourceTask to be an IO-readable with an HTTP-specific definition for its timestamp Extracted Analytics-specific classes: - JsonFileTask's timestamp is dependent on an internal property (unique to homebrew's analytics json structure) - NpmApiTask is an HttpResourceTask for JSON resources but needs a custom timestamp because the api doesn't provide Last-Modified header - BrewApiTask is an HttpResourceTask that represents JSON resources
Apparently, OpenURI#read can only be called once. The value is not buffered or preserved. Subsequent reads return the empty string. Somewhere, read was getting called a second time, so the very first http task was returning "" for the contents. This change now memoizes the results of read and json so the body is not lost (and the JSON isn't parsed more often than necessary). This introduces a tradeoff between memory consumption and performance, since the json data for all files will be saved in memory. Memory-sensitive scenarios will want to override this. Also, improve the filter/map to use grep which filters and maps at the same time. (Needs only a single pass of the array.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic Rake extensions:
in any IO-readable)
definition for its timestamp
Extracted Analytics-specific classes:
to homebrew's analytics json structure)
custom timestamp because the api doesn't provide Last-Modified header
Also includes initial scrape of npm data and bugfix for homebrew's analytics.
This is step 1 for #9
Also for reference: https://github.com/npm/registry/blob/master/docs/download-counts.md