Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds caveats for node-build plugins #60

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Adds caveats for node-build plugins #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions node-build-jxcore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ def install
system "./install.sh"
end

def caveats
<<~MSG
For `node-build`/`nodenv install` to pick up definitions provided by this plugin,
ensure '#{share/"node-build"}' exists in NODE_BUILD_DEFINITIONS.

export NODE_BUILD_DEFINITIONS="#{share/"node-build"}"
MSG
end

test do
system "ls", "#{share}/node-build"
end
Expand Down
9 changes: 9 additions & 0 deletions node-build-prerelease.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ def install
system "./install.sh"
end

def caveats
<<~MSG
For `node-build`/`nodenv install` to pick up definitions provided by this plugin,
ensure '#{share/"node-build"}' exists in NODE_BUILD_DEFINITIONS.

export NODE_BUILD_DEFINITIONS="#{share/"node-build"}"
MSG
end

test do
system "ls", "#{share}/node-build"
end
Expand Down
11 changes: 10 additions & 1 deletion node-build-update-defs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@ def install
prefix.install Dir["*"]
end

def caveats
<<~MSG
For `node-build`/`nodenv install` to pick up definitions written by this plugin,
ensure '#{share/"node-build"}' exists in NODE_BUILD_DEFINITIONS.

export NODE_BUILD_DEFINITIONS="#{share/"node-build"}"
MSG
end

test do
assert_match /^update-version-defs$/, shell_output("nodenv commands")
assert_match(/^update-version-defs$/, shell_output("nodenv commands"))
end
end