Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for musl libc #722

Open
augustobmoura opened this issue Dec 27, 2021 · 2 comments
Open

Support for musl libc #722

augustobmoura opened this issue Dec 27, 2021 · 2 comments

Comments

@augustobmoura
Copy link

Currently, node-build is downloading the generic glibc binary for Linux independently of which libc the system uses. This is a problem in systems that use musl libc (Alpine, for example).

Node.js provides experimental pre-compiled binaries for musl, aside from being able to be built from source with musl. We should at least compile from source when the libc present is different from glibc, and optionally provide the download of the pre-compiled binaries from the unofficial builds.

I suggest modifying the platform function to append -musl to the system arch when in a distro using musl libc. I will work on a PR for it.

Related to asdf-vm/asdf-nodejs#190

@augustobmoura
Copy link
Author

augustobmoura commented Dec 27, 2021

Incidentally, we could support all the other experimental pre-compiled binaries at https://github.com/nodejs/unofficial-builds#builds

@amkisko
Copy link

amkisko commented May 5, 2022

Hey! It was quite long path until I got here, also maybe this can bring some ideas on implementation: https://gist.github.com/ralexandr/8d991531360123dff9b9f72faaa0f0de - nvm supports patching and I was looking for something similar in nodenv, but unfortunately no such built-in things available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants