Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Contain matching exercise within comprehension exercise #476

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

toshify
Copy link
Collaborator

@toshify toshify commented Feb 27, 2024

Because we want to keep information on screen
so that users won't have to scroll
(as long as the content can be kept at a legible size regardless)

this commit will:

  • change the styling of the matching exercise to ensure it stays contained within its designated area when displayed within a comprehension exercise

Certification

  • I certify that
  • I have read the contributing guidelines
  • I license these contributions to the public under Seedlingo's LICENSE and have the rights to do so.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-476.dheqk4e07yyd1.amplifyapp.com

Because we want to keep information on screen
so that users won't have to scroll
(as long as the content can be kept at a legible size regardless)

this commit will:
- change the styling of the matching exercise
  to ensure it stays contained within its designated area
  when displayed within a comprehension exercise

**Certification**
- [X] I certify that <!-- Check the box to certify: [X] -->
- I have read the [contributing guidelines](
  https://github.com/nodepa/seedlingo/blob/main/.github/CONTRIBUTING.md)
- I license these contributions to the public under Seedlingo's
  [LICENSE](https://github.com/nodepa/seedlingo/blob/main/LICENSE.md)
  and have the rights to do so.

Signed-off-by: toshify <4579559+toshify@users.noreply.github.com>
@toshify toshify merged commit f80b804 into nodepa:main Feb 27, 2024
1 of 2 checks passed
@toshify toshify deleted the fix/comprehension-overflow branch February 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant