Adding github config file for adding the github variables there #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!input['gh-token'] && process.env.GITHUB_TOKEN) { | ||
| input['gh-token'] = process.env.GITHUB_TOKEN | ||
| // Checking it Github variables exist in '/config/github.js' | ||
| if (fs.exists('../config/github')) { |
There was a problem hiding this comment.
This path is a rather random path. How about putting it in ~/.nodeschool-admin.json ?
There was a problem hiding this comment.
Way better, will fix as soon as I get home.
|
@fforres alive? |
|
Hey @fforres are you still working on this one ? |
|
The github configuration is only required due to its necessity for "list" which can be implemented entirely using http://team.nodeschool.io/teams.json now. Therefore this PR became irrelevant as far as I can tell. Will close it. @fforres Please let me know if this was premature. |
martinheidegger
deleted the
enhancement/adding_git_variables_to_token_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #20