Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New slides and integrate gh-pages branch in master #6

Merged
merged 42 commits into from
Aug 19, 2019

Conversation

tobiastimm
Copy link

I've created new slides with spectacle.

We should give the NodeSchool Munich site a facelift and also update the workflow to deploy the gh-pages branch.

Something node.js based would be great, because then we can deploy it via npm and also build the slides directory before the deploy

I can try to migrate the current site to react, if you want

@tobiastimm tobiastimm marked this pull request as ready for review July 28, 2019 12:53
@tobiastimm
Copy link
Author

@meaku The website is ready. It isn't perfect and maybe the responsiveness could be improved. I just adapted most of the things to gatsby. Maybe we could also reuse the old sass and just built everything with gatsby. Also, the slides need to be built with the page. I will try to solve those issues asap.

@tobiastimm
Copy link
Author

Maybe we should move the slides into a separate repo. It needs a lot of bash magic to make the deploy easy otherwise 😢

@meaku
Copy link
Contributor

meaku commented Aug 7, 2019

Great stuff @tobiastimm! How about a different branch for slides?
Downside would be that it's not on the github pages right... but we can't create new repos under the NodeSchool org.

@tobiastimm
Copy link
Author

I will take a look at this and try to resuse the old scss and integrate the slides smoothly

@tobiastimm
Copy link
Author

tobiastimm commented Aug 10, 2019

@meaku It is now using the old scss and the slides are working too.

All you need to do is run yarn && yarn deploy and the newest site with slides should be on the gh-pages branch. We could define an action for that.

The slides are available under /slides

@meaku meaku merged commit c757540 into nodeschool:master Aug 19, 2019
@meaku
Copy link
Contributor

meaku commented Aug 19, 2019

Great stuff! Thank you so much for all the work! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants