Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean Translation #282

Merged
merged 1 commit into from
Apr 16, 2015
Merged

Conversation

marocchino
Copy link
Member

No description provided.

@marocchino
Copy link
Member Author

I also add hexdex link (#279)

@marocchino
Copy link
Member Author

@nodeschool/seoul review please. 🙇

@@ -23,10 +26,11 @@
"index-upcoming-loading": "불러오는 중...",
"index-upcoming-error": "죄송합니다. 이벤트를 불러올 수 없습니다",
"index-upcoming-all-events": "모든 이벤트 보기",
"index-upcoming-no-events": "다가올 이벤트가 없습니다 . 확인 하세요",
"index-upcoming-no-events": "다가올 이벤트가 없습니다.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다가올 -> 다가오는?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about "개최될"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace '이벤트' with '일정'?

Also, how about '예정된'?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for '예정된'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take 예정된.

@marocchino
Copy link
Member Author

@yous 이벤트 can not replace with 일정. It is not natural some context likes:

languages/ko.json:112:  "about-header": "NodeSchool은 오픈소스 프로젝트로 두가지 목적으로 만들어 졌습니다. 좋은 질을 가진 프로그래밍 커리큘럼을 만드는 것과 배움을 위한 커뮤니티 이벤트를 개최하는 것입니다.",
languages/ko.json:122:  "about-info": "우리는 남극대륙을 제외한 모든 대륙에서 커뮤니티 이벤트를 개최하고 있습니다. 누구나 이벤트의 주인이 될 수 있습니다. 그리고 모두에게 즐거운 이벤트를 만들기 위한 유용한 정보나 지침 또는 팁등을 제공하고 있습니다. 자세한 내용은 이벤트 페이지를 참고하세요.",
languages/ko.json:135:  "host-header": "NodeSchool 이벤트를 개최하세요",
languages/ko.json:136:  "host-info": "NodeSchool은 전적으로 커뮤니티 지향적이고 100% 오픈소스로 운영됩니다. 이는 누구나 NodeSchool의 모든 자료를 사용하거나 이벤트를 개최할 수 있음을 의미합니다.",
languages/ko.json:143:  "host-chapter-link2": "이벤트 개최",
languages/ko.json:144:  "host-event-header": "이벤트를 개최하세요!",
languages/ko.json:145:  "host-event-info": "<span>NodeSchool 이벤트를 개최하려면,</span> <a href='https://docs.google.com/forms/d/1vYW-Yw82kt_q7WDgBY6gQqFrg3zuD2rDPXEG-cbq7e4/viewform?usp=form_confirm' target='_blank'>이 입력 양식(영어)</a><span>을 작성하세요.</span>",
languages/ko.json:147:  "host-attend-info": "NodeSchool 이벤트 개최 일정이 정해시시면 ",
languages/ko.json:151:  "host-recommendation-info": "위 링크에서 얘기된 수많은 다양한 이벤트를 개최하기 위한 방법이 있습니다.여기 저희가 많은 이벤트를 겪으면서 얻은 경험을 토대로 약간의 팁을 아래에 적어드립니다.",

@marocchino marocchino force-pushed the update-korean branch 2 times, most recently from 86cf53c to cd0ce93 Compare April 16, 2015 16:16
@yous
Copy link
Member

yous commented Apr 16, 2015

@marocchino I got it. I'm fine with that.

@marocchino
Copy link
Member Author

@yous Are you still review this?

@yous
Copy link
Member

yous commented Apr 16, 2015

@marocchino I'm done. 😄

@marocchino
Copy link
Member Author

Thanks!

marocchino added a commit that referenced this pull request Apr 16, 2015
@marocchino marocchino merged commit 58a99f4 into nodeschool:master Apr 16, 2015
@marocchino marocchino deleted the update-korean branch April 16, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants