This repository has been archived by the owner on May 8, 2018. It is now read-only.
Fix nsp CLI crash in the no window (CI) envs #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Fixes the following crash:
> nsp check
```
/var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/node_modules/cli-table/lib/utils.js:11
return Array(times + 1).join(str);
^
RangeError: Invalid array length
at exports.repeat (/var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/node_modules/cli-table/lib/utils.js:11:10)
at line (/var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/node_modules/cli-table/lib/index.js:140:11)
at lineTop (/var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/node_modules/cli-table/lib/index.js:154:13)
at Table.toString (/var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/node_modules/cli-table/lib/index.js:252:5)
at /var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/lib/formatters/default.js:48:27
at Array.forEach (native)
at Object.module.exports (/var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/lib/formatters/default.js:33:6)
at /var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/lib/commands/check.js:25:23
at /var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/lib/check.js:240:7
at /var/lib/buildkite-agent/builds/ip-10-0-51-163-1/app/node_modules/nsp/node_modules/wreck/lib/index.js:472:20
```
|
Hello @nlf We are trying to apply Do you think this PR worth publishing a PATCH npm release? Thanks |
|
While we're adding a guard statement, we might as well just make this a full on if statement inside the isTTY one to make sure width is > 0, not just "truthy" |
|
@wraithgar @nlf Good suggestion. I've just pushed the fix. Please review. |
|
Hello there. Looking to incorporate nsp into our CI. Do you need help maintaining the project? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes the following crash: