Skip to content
This repository has been archived by the owner on Feb 20, 2021. It is now read-only.

Permission issues when running NODE_ENV=development and DEV_MODE=true #61

Closed
lholmquist opened this issue Mar 27, 2018 · 6 comments
Closed
Assignees
Labels

Comments

@lholmquist
Copy link
Contributor

i'm working on this nodeshift issue, nodeshift/nodeshift#208 to get buildConfig env vars, so i set NODE_ENV=development in my buildConfig and the build phase works fine with installing dev deps.

But during the pod deploy, i get permission issues now, when trying to load with nodemon(since DEV_MODE=true is set because of the development node env)

screen shot 2018-03-27 at 8 49 01 am

i thought by moving https://github.com/bucharest-gold/centos7-s2i-nodejs/blob/master/s2i/assemble#L61 down a little, it would fix it. but i'm either doing something wrong, which is very possible, or that wasn't the problem

@lance
Copy link
Contributor

lance commented Mar 27, 2018

Related: #38

@lance
Copy link
Contributor

lance commented Mar 27, 2018

@lholmquist I think this is what is biting us. I wonder if doing npm cache clean at the end of the assemble script might work. Is it easy enough to try that locally?

@lholmquist
Copy link
Contributor Author

let me try.

@lholmquist
Copy link
Contributor Author

I think i got something working here.

lholmquist@4a3b1e8

Basically, i moved the block of code that cleaned the npm cache and then fixed the write permissions down a little, so both a "production" and "development" environment will run it

@lance
Copy link
Contributor

lance commented Mar 27, 2018

Fixed in: db8b853

@lance lance closed this as completed Mar 27, 2018
@ghost ghost removed the in progress label Mar 27, 2018
@lance
Copy link
Contributor

lance commented Mar 27, 2018

@lholmquist new images have been pushed for latest, 9.x and 8.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants