BuildConfig: adding environment variables

[lholmquist]

It is possible to add env vars to the buildConfig, https://docs.openshift.com/container-platform/3.7/rest_api/apis-build.openshift.io/v1.BuildConfig.html#object-schema

This would be good if someone needs to install dev dependencies during the build phase(they've set NODE_ENV=dev) or if they are wanting to use yarn, and need to set the YARN_ENABLED flag, https://github.com/bucharest-gold/centos7-s2i-nodejs/blob/master/s2i/assemble#L47

but what is the best way to do this for nodeshift. How should they be passed in? using a flag from the cli, or taking into account NODE_ENV vars that are placed at the beginning? or a combo?

Then also we need to make sure the programatic api gets them too.

[lholmquist]

After looking at this a bit, i think i'm going to add a --build.env flag that can be used multiple times similar to the current -d flag, which allows multiple KEY=VALUE pairs to be passed in.

i was going to just do a -e flag but env vars can also go on the deployment config.