Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route enricher is not overriding spec:to:name #184

Closed
lholmquist opened this issue Feb 7, 2018 · 0 comments · Fixed by #185
Closed

Route enricher is not overriding spec:to:name #184

lholmquist opened this issue Feb 7, 2018 · 0 comments · Fixed by #185
Assignees
@lholmquist
Labels
bug

Comments

@lholmquist
Copy link
Member

If a user specifies a route, with certain properties, the "defualt" generated one should get overriden with these values.

This mostly happens, except for the spec:to:name property
@lholmquist lholmquist added the bug label Feb 7, 2018
lholmquist added a commit to lholmquist/nodejs-rest-http that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files.
7334af1 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
@lholmquist lholmquist mentioned this issue Feb 7, 2018
Merged
lholmquist added a commit to nodeshift-starters/nodejs-rest-http that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files. (#68)
5efe580 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to lholmquist/nodejs-rest-http-crud that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files.
0322480 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
@lholmquist lholmquist mentioned this issue Feb 7, 2018
Merged
lholmquist added a commit to nodeshift-starters/nodejs-rest-http-crud that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files. (#68)
57e73a2 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to lholmquist/nodejs-configmap that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files.
143d7a4 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to lholmquist/nodejs-rest-http-secured that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files.
7b7df07 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to nodeshift-archived/nodejs-configmap-redhat that referenced this issue Feb 7, 2018
@lholmquist
fix: remove unneeded yaml files.
e95d6db 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
@lance lance mentioned this issue Feb 7, 2018
Merged
lance added a commit to nodeshift-starters/nodejs-circuit-breaker that referenced this issue Feb 7, 2018
@lance
fix: remove unnecessary yml metadata (#28)
944a7bd 
This is the quick fix for production booster experiencing this: nodeshift/nodeshift#184
@lance lance mentioned this issue Feb 7, 2018
Merged
lholmquist added a commit to lholmquist/nodejs-health-check that referenced this issue Feb 8, 2018
@lholmquist
fix: remove unneeded yaml files.
1f79042 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
@lholmquist lholmquist mentioned this issue Feb 8, 2018
Merged
gastaldi pushed a commit to fabric8-launcher/launcher-booster-catalog that referenced this issue Feb 8, 2018
@lholmquist @gastaldi
update nodejs boosters. (#152)
3ba8e2a 
This fixes issues with route creation by nodeshift.

see nodeshift/nodeshift#184
lholmquist added a commit to nodeshift-archived/nodejs-rest-http-redhat that referenced this issue Feb 8, 2018
@lholmquist
fix: remove unneeded yaml files.
14781c7 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to nodeshift-archived/nodejs-rest-http-crud-redhat that referenced this issue Feb 8, 2018
@lholmquist
fix: remove unneeded yaml files.
8f24d4f 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to nodeshift-archived/nodejs-rest-http-secured-redhat that referenced this issue Feb 8, 2018
@lholmquist
fix: remove unneeded yaml files.
004181b 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to nodeshift-archived/nodejs-health-check-redhat that referenced this issue Feb 8, 2018
@lholmquist
fix: remove unneeded yaml files.
5d1ec5f 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
lholmquist added a commit to nodeshift-archived/nodejs-circuit-breaker-redhat that referenced this issue Feb 8, 2018
@lholmquist
fix: remove unneeded yaml files.
e13fdd2 
Since we are using some of the defaults, we can remove certain application yaml files.

There is also a bug in nodeshift, nodeshift/nodeshift#184, which this will fix
@lholmquist lholmquist self-assigned this Feb 9, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Feb 9, 2018
@lholmquist
bug(route-spec): update route spec definition to not overwrite the sp…
26732b2 
…ec:to:name property if one is specified.

fixes nodeshift#184
@lholmquist lholmquist mentioned this issue Feb 9, 2018
Merged
lholmquist added a commit that referenced this issue Feb 12, 2018
@lholmquist
bug(route-spec): update route spec definition to not overwrite the sp…
89934b5 
…ec:to:name property if one is specified. (#185)

fixes #184
@ghost ghost removed the needs-review label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lholmquist lholmquist

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(route-spec): don't mod spec:to if one exists lholmquist/nodeshift
1 participant
@lholmquist