Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbuild command? #190

Closed
lholmquist opened this issue Feb 14, 2018 · 3 comments · Fixed by #193
Closed

unbuild command? #190

lholmquist opened this issue Feb 14, 2018 · 3 comments · Fixed by #193
Assignees
Labels

Comments

@lholmquist
Copy link
Member

Currently we have undeploy, this removes the application specific stuff that gets created during the apply-resource goal.

We don't have anything currently exposed that will remove the buildConfig, builds and Imagestreams that we create during the build phase.

there is the build.recreate option that a user can pass in to remove builds/imagestreams, but a build is run after that.

This would be more a method for our integration test framework, rhoaster. The code is there to delete these things, but it is inside of the build and imagstream files. We would need to break that out into its own thing perhaps.

I don't really like the name "unbuild" so i'm open to suggestions.

@helio-frota
Copy link
Member

  • removeBuild
  • deleteBuild
  • undoBuild 👎
  • destroy
  • erase
  • undo

@lance
Copy link
Member

lance commented Feb 19, 2018

Would it be useful maybe to have undeploy accept a flag that tells it to remove everything?

@lholmquist
Copy link
Member Author

i think having that flag for undeploy might be how i go. i'll try that out first and see how it feels

lholmquist added a commit to lholmquist/nodeshift that referenced this issue Feb 21, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Feb 21, 2018
…ds, buildConfigs and Imagestreams

nodeshift undeploy removeAll

fixes nodeshift#190
@ghost ghost added review and removed in progress ready labels Feb 21, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Feb 21, 2018
…ds, buildConfigs and Imagestreams

nodeshift undeploy removeAll

fixes nodeshift#190
@ghost ghost removed the in progress label Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants