-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove message about node version choice #194
Comments
Easy thing is to remove the check. More fancy and of questionable benefit is to simply check major version number through a regex. |
@lholmquist I agree with @lance |
probably just going to remove the check |
@lholmquist Makes sense - we just need to have a user-friendly failure mode when the node version specified is not available |
hmmmm. i'll have to think about that one. the error will happen during the build on openshift, so i might need to parse the error message that is returned. i'll play with it |
…ode versions. fixes nodeshift#194
Currently if the
--nodeVersion
flag is used with a version that is not in our hard-coded list https://github.com/bucharest-gold/nodeshift/blob/master/bin/nodeshift#L29,then we emit a warning.
We started talking about have more point releases as well as
cr
releases, i'm tempted to take this check out@lance @helio-frota any thoughts
The text was updated successfully, but these errors were encountered: