Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message about node version choice #194

Closed
lholmquist opened this issue Mar 1, 2018 · 5 comments · Fixed by #195
Closed

Remove message about node version choice #194

lholmquist opened this issue Mar 1, 2018 · 5 comments · Fixed by #195
Assignees
Labels

Comments

@lholmquist
Copy link
Member

lholmquist commented Mar 1, 2018

Currently if the --nodeVersion flag is used with a version that is not in our hard-coded list https://github.com/bucharest-gold/nodeshift/blob/master/bin/nodeshift#L29,
then we emit a warning.

We started talking about have more point releases as well as cr releases, i'm tempted to take this check out

@lance @helio-frota any thoughts

@lance
Copy link
Member

lance commented Mar 1, 2018

Easy thing is to remove the check. More fancy and of questionable benefit is to simply check major version number through a regex.

@helio-frota
Copy link
Member

@lholmquist I agree with @lance

@lholmquist
Copy link
Member Author

probably just going to remove the check

@lance
Copy link
Member

lance commented Mar 1, 2018

@lholmquist Makes sense - we just need to have a user-friendly failure mode when the node version specified is not available

@lholmquist
Copy link
Member Author

hmmmm. i'll have to think about that one. the error will happen during the build on openshift, so i might need to parse the error message that is returned. i'll play with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants