Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment environment variables #223

Closed
lholmquist opened this issue May 18, 2018 · 0 comments · Fixed by #226
Closed

Add deployment environment variables #223

lholmquist opened this issue May 18, 2018 · 0 comments · Fixed by #226
Assignees

Comments

@lholmquist
Copy link
Member

If someone wanted to add some environment variables to their deployment config, they would have to create a deploymentConfig.yaml and place it in the .nodeshift directory

I think we can probably add a cli flag called --deploy.env that will allow the user to add 1 or more environment variables.

This is sort of the same thing that happens with the --build.env flag, but for buildConfigs

@lholmquist lholmquist self-assigned this May 18, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue May 21, 2018
This will allow users to pass in environment variables that should be added to a deployment config.

ex: nodeshift --deploy.env NODE_ENV=development

If a deployment.yaml in the .nodeshift directory already exists with environment variables, they will be merged together
If there are duplicate vars, the ones passed in from the cli/api will take precedence.

fixes nodeshift#223
@ghost ghost added review and removed in progress labels May 21, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue May 22, 2018
This will allow users to pass in environment variables that should be added to a deployment config.

ex: nodeshift --deploy.env NODE_ENV=development

If a deployment.yaml in the .nodeshift directory already exists with environment variables, they will be merged together
If there are duplicate vars, the ones passed in from the cli/api will take precedence.

fixes nodeshift#223
lholmquist added a commit that referenced this issue May 22, 2018
This will allow users to pass in environment variables that should be added to a deployment config.

ex: nodeshift --deploy.env NODE_ENV=development

If a deployment.yaml in the .nodeshift directory already exists with environment variables, they will be merged together
If there are duplicate vars, the ones passed in from the cli/api will take precedence.

fixes #223
@ghost ghost removed the review label May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant