feat: add the --deploy.env flag #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
This will allow users to pass in environment variables that should be added to a deployment config. ex: nodeshift --deploy.env NODE_ENV=development If a deployment.yaml in the .nodeshift directory already exists with environment variables, they will be merged together If there are duplicate vars, the ones passed in from the cli/api will take precedence. fixes nodeshift#223
lholmquist
force-pushed
the
223-deploy-env
branch
from
cfce793
to
11dd507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to pass in environment variables that should be added to a deployment config.
ex: nodeshift --deploy.env NODE_ENV=development
If a deployment.yaml in the .nodeshift directory already exists with environment variables, they will be merged together
If there are duplicate vars, the ones passed in from the cli/api will take precedence.
fixes #223