Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the nodeVersion flag to imageTag #256

Closed
lholmquist opened this issue Jul 26, 2018 · 0 comments · Fixed by #258
Closed

Change the nodeVersion flag to imageTag #256

lholmquist opened this issue Jul 26, 2018 · 0 comments · Fixed by #258
Assignees
@lholmquist
Labels
enhancement

Comments

@lholmquist
Copy link
Member

currently when using nodeshift and you want to change the node version of the centos-s2i-nodejs image, you can use the --nodeVersion flag. something like --nodeVersion=8.x.

It sort of makes sense for that image because the version is also the docker image tag.

But it is also sort of misleading. It really should be --imageTag, since that is the thing that flag changes

I think we can add this, but also keep the --nodeVersion flag and possibly just add a deprecation message.

Once we move to 2.0.0 we could probably remove the old flag.
@lance lance added the next label Aug 8, 2018
@lholmquist lholmquist self-assigned this Aug 10, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Aug 13, 2018
@lholmquist
feat: add the imageTag flag.
e8418d0 
This also deprecates the use of the --nodeVersion flag, which will be removed in the 2.0 version.

fixes nodeshift#256
@lholmquist lholmquist mentioned this issue Aug 13, 2018
Merged
@ghost ghost added review and removed in progress labels Aug 13, 2018
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Aug 13, 2018
@lholmquist
feat: add the imageTag flag.
abb2eff 
This also deprecates the use of the --nodeVersion flag, which will be removed in the 2.0 version.

fixes nodeshift#256
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Aug 14, 2018
@lholmquist
feat: add the imageTag flag.
c255dec 
This also deprecates the use of the --nodeVersion flag, which will be removed in the 2.0 version.

fixes nodeshift#256
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Aug 14, 2018
@lholmquist
feat: add the imageTag flag.
8e3fcf0 
This also deprecates the use of the --nodeVersion flag, which will be removed in the 2.0 version.

fixes nodeshift#256
lholmquist added a commit that referenced this issue Aug 14, 2018
@lholmquist
feat: add the imageTag flag. (#258)
399081e 
* feat: add the imageTag flag.

This also deprecates the use of the --nodeVersion flag, which will be removed in the 2.0 version.

fixes #256

* remove the default choice for nodeVersion
@ghost ghost removed the review label Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lholmquist lholmquist

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add the imageTag flag. lholmquist/nodeshift
2 participants
@lance @lholmquist