Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in loading projectLocation #301

Closed
lholmquist opened this issue Apr 1, 2019 · 0 comments · Fixed by #302
Closed

Bug in loading projectLocation #301

lholmquist opened this issue Apr 1, 2019 · 0 comments · Fixed by #302
Assignees
@lholmquist
Labels
bug Good First Issue

Comments

@lholmquist
Copy link
Member

There seems to be a bug when loading the projectLocation, if you don't specify the full path to the project, it will return an error that it cannot find the projects package.json

I think the way nodeshift is loading this, is relative to the nodeshift-config.js file, which isn't correct
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Apr 1, 2019
@lholmquist
fix: load the projectLocation not relative to the nodeshift-config.js…
c3ee42e 
… file

* This makes it so you don't need to use the full directory path when specifing the projectLocation.

* project location will be loaded relative to your current working directory.

fixes nodeshift#301
@lholmquist lholmquist mentioned this issue Apr 1, 2019
Merged
@lholmquist lholmquist self-assigned this Apr 1, 2019
lholmquist added a commit that referenced this issue Apr 2, 2019
@lholmquist
fix: load the projectLocation not relative to the nodeshift-config.js…
eaf0046 
… file (#302)

* This makes it so you don't need to use the full directory path when specifing the projectLocation.

* project location will be loaded relative to your current working directory.

fixes #301
@lholmquist lholmquist removed the review label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lholmquist lholmquist

Labels
bug Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: load the projectLocation not relative to the nodeshift-config.js… lholmquist/nodeshift
1 participant
@lholmquist