Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: ability to specify output image name #337

Closed
lance opened this issue Jul 15, 2019 · 2 comments · Fixed by #347
Closed

Enhancement: ability to specify output image name #337

lance opened this issue Jul 15, 2019 · 2 comments · Fixed by #347
Assignees

Comments

@lance
Copy link
Member

lance commented Jul 15, 2019

It would be nice to have the ability to give a name to the output image from the build task. It's nice that nodeshift already uses the name from package.json. But it would be good for pipelines to be able to specify a given run what the output image name - for example my-webapp-staging and my-webapp-production.

@lance lance added this to Inbox in Tooling and Modules via automation Jul 15, 2019
@lholmquist
Copy link
Member

This would be a nice addition and it sort of goes along with a TODO item that i've had in the code for a while around being able to specify a tag name instead of just using latest,

Since we are always using latest, we are overwriting the previous "version" of the imagestream during every build.

Another thing that might also make sense, is the ability to specify different buildConfigs? Currently when you run nodeshift a default buildConfig is created, then this is used on subsequent calls to nodeshift unless the flag to recreate is specified. It could be interesting if you had the ability to specify a previously created buildConfig without having to re-create each time

I'm sort of hijacking this issue, but i think they logically go together.

@lance
Copy link
Member Author

lance commented Jul 16, 2019

@lholmquist @helio-frota I think the implementation for the image name + tag could be very simple. E.g.

config.outputImageTag = config.outputImageTag ? config.outputImageTag : 'latest';
const outputImageStreamTag = `${config.outputImage}:${config.outputImageTag}`;

And of course, adding outputImage and outputImageTag as command line options so they end up on the config object.

I think the flexibility you'd get by naming the BuildConfig would be nice. But yeah, that's a different issue. :)

lholmquist added a commit to lholmquist/nodeshift that referenced this issue Aug 1, 2019
@lholmquist lholmquist moved this from Inbox to In progress in Tooling and Modules Aug 1, 2019
@lholmquist lholmquist self-assigned this Aug 1, 2019
Tooling and Modules automation moved this from In progress to Done Aug 19, 2019
lholmquist added a commit that referenced this issue Aug 19, 2019
* feat: change the output Image Stream name and tag

fixes #337

* squash: fix existing tests

* squash: update docs and api docs

* squash: fix typo

* chore: update all Image Streams to ImageStream for consistency

* squash: fix test after ImageStream text updates

* squash: update to use output image tag instead of latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants