-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: ability to specify output image name #337
Comments
This would be a nice addition and it sort of goes along with a TODO item that i've had in the code for a while around being able to specify a tag name instead of just using latest, Since we are always using latest, we are overwriting the previous "version" of the imagestream during every build. Another thing that might also make sense, is the ability to specify different buildConfigs? Currently when you run I'm sort of hijacking this issue, but i think they logically go together. |
@lholmquist @helio-frota I think the implementation for the image name + tag could be very simple. E.g. config.outputImageTag = config.outputImageTag ? config.outputImageTag : 'latest';
const outputImageStreamTag = `${config.outputImage}:${config.outputImageTag}`; And of course, adding I think the flexibility you'd get by naming the |
* feat: change the output Image Stream name and tag fixes #337 * squash: fix existing tests * squash: update docs and api docs * squash: fix typo * chore: update all Image Streams to ImageStream for consistency * squash: fix test after ImageStream text updates * squash: update to use output image tag instead of latest
It would be nice to have the ability to give a name to the output image from the
build
task. It's nice that nodeshift already uses thename
frompackage.json
. But it would be good for pipelines to be able to specify a given run what the output image name - for examplemy-webapp-staging
andmy-webapp-production
.The text was updated successfully, but these errors were encountered: