Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in different configs like in the openshift-rest-client #341

Closed
helio-frota opened this issue Jul 16, 2019 · 1 comment · Fixed by #400 or nodeshift-archived/rhoaster#33
Closed

Pass in different configs like in the openshift-rest-client #341

helio-frota opened this issue Jul 16, 2019 · 1 comment · Fixed by #400 or nodeshift-archived/rhoaster#33
Labels
question
Projects
Tooling and Modules

Comments

@helio-frota
Copy link
Member

https://github.com/nodeshift/nodeshift/blob/master/lib/nodeshift-config.js#L34
@lholmquist lholmquist added this to Backlog in Tooling and Modules Aug 7, 2019
@lholmquist
Copy link
Member

I think once this is in, nodeshift/openshift-rest-client#189, we will be able to pass in a new "configLocation" that points to the config location on the filesystem.

lholmquist added a commit to lholmquist/nodeshift that referenced this issue Jan 21, 2020
@lholmquist
feat: pass in a non-default configLocation.
c2f050e 
This allows a user to pass in a new location for a kubernetes/openshift configuration file.

fixes nodeshift#341
@lholmquist lholmquist mentioned this issue Jan 21, 2020
Merged
@lholmquist lholmquist moved this from Backlog to Reviewer approved in Tooling and Modules Jan 22, 2020
Tooling and Modules automation moved this from Reviewer approved to Done Jan 22, 2020
lholmquist added a commit that referenced this issue Jan 22, 2020
@lholmquist
feat: pass in a non-default configLocation. (#400)
f1bd1b3 
This allows a user to pass in a new location for a kubernetes/openshift configuration file.

fixes #341, #373
This was referenced Mar 25, 2020
Closed
Closed
Closed
Merged
Closed
This was referenced Apr 6, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
Tooling and Modules
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass in a non-default configLocation. lholmquist/nodeshift
[Snyk] Upgrade nodeshift from 4.0.0 to 6.0.1 nodeshift-archived/rhoaster
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-starters/nodejs-health-check
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-starters/nodejs-rest-http
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-starters/nodejs-rest-http-crud
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-starters/nodejs-configmap
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-archived/nodejs-messaging-work-queue-redhat
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-archived/nodejs-rest-http-secured-redhat
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-archived/nodejs-health-check-redhat
[Snyk] Upgrade nodeshift from 4.1.0 to 6.0.1 nodeshift-archived/nodejs-cache-redhat
2 participants
@lholmquist @helio-frota