-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change the output Image Stream name and tag #347
Merged
lholmquist
merged 7 commits into
nodeshift:master
from
lholmquist:337-output-image-name
Aug 19, 2019
Merged
feat: change the output Image Stream name and tag #347
lholmquist
merged 7 commits into
nodeshift:master
from
lholmquist:337-output-image-name
Aug 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will do perhaps tomorrow or early next week. Feel free to bug me about it
again if it slips through the cracks.
|
Pull Request Test Coverage Report for Build 887
💛 - Coveralls |
helio-frota
requested changes
Aug 2, 2019
@lance just a friendly ping :) |
lance
reviewed
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, but I have a few questions about the use of outputImageStreamTag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #337
@lance when you get a chance, you want to test this out.
I still need to added tests and update the readme and and stuff. but the functionality should all be there
there are now
--outputImageStream
and--outputImageStreamTag
flags to specify the different output stream names and tag