Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the output Image Stream name and tag #347

Merged
merged 7 commits into from
Aug 19, 2019

Conversation

lholmquist
Copy link
Member

fixes #337

@lance when you get a chance, you want to test this out.

I still need to added tests and update the readme and and stuff. but the functionality should all be there

there are now --outputImageStream and --outputImageStreamTag flags to specify the different output stream names and tag

@lholmquist lholmquist added this to Review in progress in Tooling and Modules via automation Aug 1, 2019
@lance
Copy link
Member

lance commented Aug 1, 2019 via email

@coveralls
Copy link

coveralls commented Aug 1, 2019

Pull Request Test Coverage Report for Build 887

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.622%

Totals Coverage Status
Change from base Build 219: 0.02%
Covered Lines: 629
Relevant Lines: 654

💛 - Coveralls

README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@lholmquist
Copy link
Member Author

@lance just a friendly ping :)

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, but I have a few questions about the use of outputImageStreamTag

bin/nodeshift Outdated Show resolved Hide resolved
lib/build-config.js Outdated Show resolved Hide resolved
lib/nodeshift-config.js Outdated Show resolved Hide resolved
@lholmquist lholmquist merged commit 3faa599 into nodeshift:master Aug 19, 2019
Tooling and Modules automation moved this from Review in progress to Done Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Enhancement: ability to specify output image name
4 participants