Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openshift runtime labels #374

Closed
lholmquist opened this issue Oct 29, 2019 · 0 comments · Fixed by #380 or nodeshift-archived/rhoaster#33
Closed

add openshift runtime labels #374

lholmquist opened this issue Oct 29, 2019 · 0 comments · Fixed by #380 or nodeshift-archived/rhoaster#33

Comments

@lholmquist
Copy link
Member

On the openshift 4.2, in the topology view, where the deployed pod is displayed, there is an icon that is in the middle. By default it is just a generic openshift icon, but with the correct labels, it can be a node.js logo.

It would be a nice to have if we could have nodeshift add in these labels. i htink the one we are looking for is the "runtime" label

docs about the labels:
https://github.com/gorkem/app-labels/blob/master/labels-annotation-for-openshift.adoc

list of icons:
https://github.com/openshift/console/blob/master/frontend/public/components/catalog/catalog-item-icon.tsx

@lholmquist lholmquist added this to Backlog in Tooling and Modules Oct 30, 2019
@lholmquist lholmquist moved this from Backlog to Inbox in Tooling and Modules Oct 30, 2019
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Nov 12, 2019
* This adds more labels to the created resources to better identify that this is a Node.js application in the Developer Topology view in Openshift 4.2

* THere are also labels added to the BuildConfig, that allows for better ux when looking at the topolgy view.

fixes nodeshift#374
lholmquist added a commit to lholmquist/nodeshift that referenced this issue Nov 12, 2019
* This adds more labels to the created resources to better identify that this is a Node.js application in the Developer Topology view in Openshift 4.2

* THere are also labels added to the BuildConfig, that allows for better ux when looking at the topolgy view.

fixes nodeshift#374
Tooling and Modules automation moved this from Inbox to Done Nov 15, 2019
lholmquist added a commit that referenced this issue Nov 15, 2019
* feat(enricher): add runtime labels to resources.

* This adds more labels to the created resources to better identify that this is a Node.js application in the Developer Topology view in Openshift 4.2

* There are also labels added to the BuildConfig, that allows for better ux when looking at the topolgy view.

fixes #374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment