Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass in a non-default configLocation. #400

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

lholmquist
Copy link
Member

@lholmquist lholmquist commented Jan 21, 2020

This allows a user to pass in a new location for a kubernetes/openshift configuration file.

fixes #341, #373

This allows a user to pass in a new location for a kubernetes/openshift configuration file.

fixes nodeshift#341
@coveralls
Copy link

coveralls commented Jan 21, 2020

Pull Request Test Coverage Report for Build 1059

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.674%

Totals Coverage Status
Change from base Build 631: 0.0%
Covered Lines: 641
Relevant Lines: 666

💛 - Coveralls

@lholmquist lholmquist added this to In progress in Tooling and Modules Jan 22, 2020
@lholmquist lholmquist moved this from In progress to Review in progress in Tooling and Modules Jan 22, 2020
@lholmquist lholmquist moved this from Review in progress to Reviewer approved in Tooling and Modules Jan 22, 2020
@lholmquist lholmquist merged commit f1bd1b3 into nodeshift:master Jan 22, 2020
Tooling and Modules automation moved this from Reviewer approved to Done Jan 22, 2020
@lholmquist lholmquist deleted the 341-config-location-pass-in branch January 22, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Pass in different configs like in the openshift-rest-client
4 participants