Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for a package name first #610

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Check for a package name first #610

merged 2 commits into from
Jan 24, 2022

Conversation

lholmquist
Copy link
Member

This PR adds a check for the name field in the package.json.

The second commit removes some rogue console.logs

@lholmquist lholmquist requested a review from a team January 21, 2022 21:51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.2% when pulling 7626e06 on lholmquist:NODE-1593-check-for-package-nam into ba304f3 on nodeshift:main.

@lholmquist lholmquist merged commit eedc44c into nodeshift:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@helio-frota helio-frota helio-frota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lholmquist @coveralls @richardlau @helio-frota