Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed currentTime to number as specified in the docs #226

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

julekgwa
Copy link
Contributor

@julekgwa julekgwa commented Sep 6, 2018

The hystrix stream data is not compatible with turbine, the specs says that currentTime is a Number but the provided type is of date string in hystrix-formatter.js. see https://github.com/Netflix/Hystrix/wiki/Metrics-and-Monitoring#metrics-publisher

fix #225

@ghost ghost added the in progress label Sep 6, 2018
@julekgwa julekgwa closed this Sep 6, 2018
@ghost ghost removed the in progress label Sep 6, 2018
@julekgwa julekgwa reopened this Sep 6, 2018
@ghost ghost added the in progress label Sep 6, 2018
@julekgwa
Copy link
Contributor Author

julekgwa commented Sep 6, 2018

Test build of the pull request

build

I don't know why the pull request fails.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julekgwa thanks for the contribution!

@lance lance merged commit b41407d into nodeshift:master Sep 11, 2018
@ghost ghost removed the in progress label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hystrix stream not compatible with turbine
2 participants