Merge pull request #204 from nodesource/minwoo/ver

1.4.0
nodesource · Mar 30, 2021 · 3025e14 · 3025e14
2 parents 9c36afb + 2439880
commit 3025e14
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,11 @@
+1.4.0 / 2021-03-24
+==================
+
+* Ensured the prevention of npm substitution attacks during `install`.
+* Added Github actions integration.
+* Fixed handling of metadata during `report`
+* Dependency updates.
+
 1.3.4 / 2019-07-30
 ==================
 

diff --git a/lib/report/github-action.js b/lib/report/github-action.js
@@ -112,6 +112,10 @@ async function updateCheck (octokit, listChecks, annotations, contextData) {
   // array of annotations
 
   const runName = core.getInput('GITHUB_JOB_NAME')
+  const logUpdateCheck = () =>
+    console.log('Unable to be sure of the check run ID, are you sure you set a name for the Job in the workflow file and passed the same to the action?')
+
+  if (!listChecks || !listChecks.data) return logUpdateCheck()
 
   for (const run of listChecks.data.check_runs) {
     if (run.name === runName) {
@@ -127,7 +131,7 @@ async function updateCheck (octokit, listChecks, annotations, contextData) {
         }
       })
     } else {
-      console.log('Unable to be sure of the check run ID, are you sure you set a name for the Job in the workflow file and passed the same to the action?')
+      logUpdateCheck()
     }
   }
 }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ncm-cli",
-  "version": "1.4.1",
+  "version": "1.4.0",
   "license": "Apache-2.0",
   "description": "Command-line tool for NodeSource Certified Modules 2.0",
   "author": "NodeSource <npm@nodesource.com> (https://nodesource.com)",