Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.4.0 #204

Merged
merged 1 commit into from
Mar 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
1.4.0 / 2021-03-24
==================

* Ensured the prevention of npm substitution attacks during `install`.
* Added Github actions integration.
* Fixed handling of metadata during `report`
* Dependency updates.

1.3.4 / 2019-07-30
==================

Expand Down
6 changes: 5 additions & 1 deletion lib/report/github-action.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ async function updateCheck (octokit, listChecks, annotations, contextData) {
// array of annotations

const runName = core.getInput('GITHUB_JOB_NAME')
const logUpdateCheck = () =>
console.log('Unable to be sure of the check run ID, are you sure you set a name for the Job in the workflow file and passed the same to the action?')

if (!listChecks || !listChecks.data) return logUpdateCheck()

for (const run of listChecks.data.check_runs) {
if (run.name === runName) {
Expand All @@ -127,7 +131,7 @@ async function updateCheck (octokit, listChecks, annotations, contextData) {
}
})
} else {
console.log('Unable to be sure of the check run ID, are you sure you set a name for the Job in the workflow file and passed the same to the action?')
logUpdateCheck()
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ncm-cli",
"version": "1.4.1",
"version": "1.4.0",
"license": "Apache-2.0",
"description": "Command-line tool for NodeSource Certified Modules 2.0",
"author": "NodeSource <npm@nodesource.com> (https://nodesource.com)",
Expand Down