Suggest solution for uploading for aws with insufficient permissions #25
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue number 24 which is related to uploading work inspite of insufficient permissions ,
First adapter upload method is resolved when result stream from createWriteStream emits finished event.
I think problem is that result stream from createWriteStream always emit finished events when it is done even when there is error so I thought of make result stream emit custom event ( I called 'uploaded') when there is no error in the callback of aws upload method and make adapter upload merhod resolve when emitting this event ( I made this case of aws adapter only)