Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for rendered output #70

Merged
merged 21 commits into from
Apr 28, 2015
Merged

Tests for rendered output #70

merged 21 commits into from
Apr 28, 2015

Conversation

Mr0grog
Copy link
Member

@Mr0grog Mr0grog commented Feb 13, 2014

We really need to test that the rendered output is correct if we want to do further work. This is an attempt to get that started.

This is a work in progress—we should get evolve a little bit of a nice structure for making these tests easier here before merging into master.

@bensheldon
Copy link
Member

👍 Goes great with #73

@bensheldon
Copy link
Member

@Mr0grog we have a merge conflict, but I think the basic functionality here adds value in its current state, even if it's not the cleanest interface. Could you please try to clean up the the conflict and we'll merge this.

@Mr0grog
Copy link
Member Author

Mr0grog commented Mar 30, 2015

Wow, I remember the alst time I looked at this code and that was a long time ago! Will see if I can make sure this is all still good to go soon. Probably a lot of old dependencies that should be updated, too :\

@bensheldon
Copy link
Member

One thing at a time :-) I'd rather have this code merged and working with existing/old dependencies than broken with new ones :-)

@Mr0grog
Copy link
Member Author

Mr0grog commented Mar 30, 2015

Oh, was not implying that that should happen on this branch. Just saying. Everything in this repo is basically two years out of date.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.76%) to 26.11% when pulling 0a0819e on bug-10-image-tests into 70a6913 on master.

@Mr0grog
Copy link
Member Author

Mr0grog commented Apr 28, 2015

Woo, and dramatically increased coverage to boot. Merging.

Mr0grog added a commit that referenced this pull request Apr 28, 2015
@Mr0grog Mr0grog merged commit 117853d into master Apr 28, 2015
@Mr0grog Mr0grog changed the title WIP: Tests for rendered output Tests for rendered output May 3, 2015
@Mr0grog Mr0grog mentioned this pull request May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants