-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for rendered output #70
Conversation
👍 Goes great with #73 |
@Mr0grog we have a merge conflict, but I think the basic functionality here adds value in its current state, even if it's not the cleanest interface. Could you please try to clean up the the conflict and we'll merge this. |
Wow, I remember the alst time I looked at this code and that was a long time ago! Will see if I can make sure this is all still good to go soon. Probably a lot of old dependencies that should be updated, too :\ |
One thing at a time :-) I'd rather have this code merged and working with existing/old dependencies than broken with new ones :-) |
Oh, was not implying that that should happen on this branch. Just saying. Everything in this repo is basically two years out of date. |
Conflicts: package.json
Woo, and dramatically increased coverage to boot. Merging. |
WIP: Tests for rendered output
We really need to test that the rendered output is correct if we want to do further work. This is an attempt to get that started.
This is a work in progress—we should get evolve a little bit of a nice structure for making these tests easier here before merging into master.