Update canvas dependency to be compatible with v1.x #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OK, as I believe canvas generally follows semver. Fixes #77.
|
👍 ...though ugh for Travis crashing out on installing Canvas module |
|
I hope you are also enjoying an inbox full of me fighting with Travis right now, too ;) |
…fore running tests.
…mpatible w/ Node 0.8
Mr0grog
force-pushed
the
77-canvas-out-of-date
branch
from
d0e91ff
to
8c7d632
Compare
|
Ok, going to merge, bump version, and publish. |
Mr0grog
added a commit
that referenced
this pull request
Apr 26, 2015
Update canvas dependency to be compatible with v1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #77, @waissbluth tripped over a dependency on an out-of-date version of Canvas that doesn’t build on the latest OS X :(
Rather than keep updating the dependency every time Canvas does a release, I’ve changed our dependency to work with any Canvas 1.x version. Since I believe Canvas uses semver, this should be safe. All our tests still pass (including new rendering tests in
bug-10-image-tests).