fix(MongoBinaryUrl): getDownloadUrl: try to create an "URL" to check …

…if the url is valid
nodkz · Mar 14, 2021 · 25c865c · 25c865c
1 parent 3ae6a45
commit 25c865c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/docs/api/config-options.md b/docs/api/config-options.md
@@ -49,7 +49,7 @@ Option `DEBUG` is used to enable Debug Output
 
 Option `DOWNLOAD_MIRROR` is used to set which mirror to use
 
-Default / Format: `https://fastdl.mongodb.org`
+Default / Format: `https://fastdl.mongodb.org` (protocol needs to be included)
 
 ### DOWNLOAD_URL
 

diff --git a/packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts b/packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts
@@ -4,6 +4,7 @@ import debug from 'debug';
 import * as semver from 'semver';
 import { isNullOrUndefined } from './utils';
 import { BaseDryMongoBinaryOptions, DryMongoBinary } from './DryMongoBinary';
+import { URL } from 'url';
 
 const log = debug('MongoMS:MongoBinaryDownloadUrl');
 
@@ -39,7 +40,9 @@ export class MongoBinaryDownloadUrl {
     if (downloadUrl) {
       log(`Using "${downloadUrl}" as the Download-URL`);
 
-      return downloadUrl;
+      const url = new URL(downloadUrl); // check if this is an valid url
+
+      return url.toString();
     }
 
     const archive = await this.getArchiveName();
@@ -49,7 +52,10 @@ export class MongoBinaryDownloadUrl {
       resolveConfig(ResolveConfigVariables.DOWNLOAD_MIRROR) ?? 'https://fastdl.mongodb.org';
     log(`Using "${mirror}" as the mirror`);
 
-    return `${mirror}/${this.platform}/${archive}`;
+    const url = new URL(mirror);
+    url.pathname = `/${this.platform}/${archive}`;
+
+    return url.toString();
   }
 
   /**