refactor(MongoMemoryReplSet): remove "async" from "getDbName"

BREAKING CHANGE: removing "async" / modifing return type "Promise<string>" can break code
nodkz · Oct 12, 2020 · 2775b4f · 2775b4f
1 parent 9b17925
commit 2775b4f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts b/packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts
@@ -166,10 +166,7 @@ export class MongoMemoryReplSet extends EventEmitter {
   /**
    * Returns database name.
    */
-  async getDbName(): Promise<string> {
-    // this function is only async for consistency with MongoMemoryServer
-    // I don't see much point to either of them being async but don't
-    // care enough to change it and introduce a breaking change.
+  getDbName(): string {
     return this.opts.replSet.dbName;
   }
 

diff --git a/packages/mongodb-memory-server-core/src/__tests__/replset-multi-test.ts b/packages/mongodb-memory-server-core/src/__tests__/replset-multi-test.ts
@@ -27,7 +27,7 @@ describe('multi-member replica set', () => {
     // await while all SECONDARIES will be ready
     await new Promise((resolve) => setTimeout(resolve, 2000));
 
-    const db = await con.db(await replSet.getDbName());
+    const db = await con.db(replSet.getDbName());
     const admin = db.admin();
     const status = await admin.replSetGetStatus();
     expect(status.members.filter((m: any) => m.stateStr === 'PRIMARY')).toHaveLength(1);

diff --git a/packages/mongodb-memory-server-core/src/__tests__/replset-single-test.ts b/packages/mongodb-memory-server-core/src/__tests__/replset-single-test.ts
@@ -27,7 +27,7 @@ describe('single server replset', () => {
   it('should be able to get dbName', async () => {
     const opts: any = { autoStart: false, replSet: { dbName: 'static' } };
     const replSet = new MongoMemoryReplSet(opts);
-    const dbName = await replSet.getDbName();
+    const dbName = replSet.getDbName();
     expect(dbName).toEqual('static');
 
     await replSet.stop();