fix(MongoMemoryServer): pass-through option "launchTimeout" correctly

re #710
nodkz · Oct 31, 2022 · 6ffe62a · 6ffe62a
1 parent 85f7e5e
commit 6ffe62a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/packages/mongodb-memory-server-core/src/MongoMemoryServer.ts b/packages/mongodb-memory-server-core/src/MongoMemoryServer.ts
@@ -72,6 +72,7 @@ export interface AutomaticAuth {
   keyfileContent?: string;
 }
 
+// TODO: consider some way to not forget to add changes from "MongoMemoryInstanceOpts"
 /**
  * Data used by _startUpInstance's "data" variable
  */
@@ -84,6 +85,7 @@ export interface StartupInstanceData {
   replSet?: NonNullable<MongoMemoryInstanceOpts['replSet']>;
   tmpDir?: tmp.DirResult;
   keyfileLocation?: NonNullable<MongoMemoryInstanceOpts['keyfileLocation']>;
+  launchTimeout?: NonNullable<MongoMemoryInstanceOpts['launchTimeout']>;
 }
 
 /**
@@ -364,6 +366,7 @@ export class MongoMemoryServer extends EventEmitter implements ManagerAdvanced {
       port = await this.getNewPort(port);
     }
 
+    // consider directly using "this.opts.instance", to pass through all options, even if not defined in "StartupInstanceData"
     const data: StartupInstanceData = {
       port: port,
       dbName: generateDbName(instOpts.dbName),
@@ -373,6 +376,7 @@ export class MongoMemoryServer extends EventEmitter implements ManagerAdvanced {
       dbPath: instOpts.dbPath,
       tmpDir: undefined,
       keyfileLocation: instOpts.keyfileLocation,
+      launchTimeout: instOpts.launchTimeout,
     };
 
     if (isNullOrUndefined(this._instanceInfo)) {

diff --git a/packages/mongodb-memory-server-core/src/__tests__/MongoMemoryServer.test.ts b/packages/mongodb-memory-server-core/src/__tests__/MongoMemoryServer.test.ts
@@ -1106,4 +1106,25 @@ describe('MongoMemoryServer', () => {
       }
     });
   });
+
+  it('should transfer "launchTimeout" option to the MongoInstance', async () => {
+    const createSpy = jest.spyOn(MongoInstance, 'create').mockImplementation(
+      // @ts-expect-error This can work, because the instance is not used in the function that is tested here, beyond setting some extra options
+      () => Promise.resolve({})
+    );
+
+    const mongoServer = new MongoMemoryServer({ instance: { launchTimeout: 2000 } });
+
+    await mongoServer._startUpInstance();
+
+    // @ts-expect-error "_instanceInfo" is protected
+    const instanceInfo = mongoServer._instanceInfo;
+    expect(instanceInfo).toBeDefined();
+    utils.assertion(!utils.isNullOrUndefined(instanceInfo));
+    expect(instanceInfo.instance).toBeDefined();
+    expect(instanceInfo?.launchTimeout).toStrictEqual(2000);
+
+    expect(createSpy.mock.calls.length).toStrictEqual(1);
+    expect(createSpy.mock.calls[0][0].instance).toHaveProperty('launchTimeout', 2000);
+  });
 });