Skip to content

Commit

Permalink
refactor(MongoMemoryReplSet): remove dynamic import "mongodb"
Browse files Browse the repository at this point in the history
- remove dynamic import "mongodb"
(because on top of the file "import * mongodb" is already executed)
  • Loading branch information
hasezoey committed Oct 12, 2020
1 parent 335780e commit fb958ae
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import { EventEmitter } from 'events';
import * as mongodb from 'mongodb';
import MongoMemoryServer from './MongoMemoryServer';
import { MongoMemoryServerOptsT } from './MongoMemoryServer';
import { assertion, ensureAsync, generateDbName, getHost, isNullOrUndefined } from './util/db_util';
import { MongoBinaryOpts } from './util/MongoBinary';
import { MongoMemoryInstancePropT, MongoMemoryInstancePropBaseT, StorageEngineT } from './types';
import debug from 'debug';
import { MongoError } from 'mongodb';
import { MongoClient, MongoError } from 'mongodb';
import { MongoInstanceEvents } from './util/MongoInstance';
import { SpawnOptions } from 'child_process';

Expand Down Expand Up @@ -390,16 +389,7 @@ export class MongoMemoryReplSet extends EventEmitter {
}
const uris = this.servers.map((server) => server.getUri());

let MongoClient: typeof mongodb.MongoClient;
try {
MongoClient = (await import('mongodb')).MongoClient;
} catch (e) {
throw new Error(
`You need to install "mongodb" package. It's required for checking ReplicaSet state.`
);
}

const con: mongodb.MongoClient = await MongoClient.connect(uris[0], {
const con: MongoClient = await MongoClient.connect(uris[0], {
useNewUrlParser: true,
useUnifiedTopology: true,
});
Expand Down

0 comments on commit fb958ae

Please sign in to comment.