Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postinstall prefers relative path over modulesCache #478

Closed
hasezoey opened this issue Jun 1, 2021 · 3 comments
Closed

Postinstall prefers relative path over modulesCache #478

hasezoey opened this issue Jun 1, 2021 · 3 comments
Labels
bug has repro script This issue has an reproduce script released on @beta released Pull Request released | Issue is fixed

Comments

@hasezoey
Copy link
Collaborator

hasezoey commented Jun 1, 2021

Versions

  • NodeJS: 0.0.0
  • mongodb-memory-server-*: 7.0.0-beta.42
  • mongodb: 0.0.0
  • system: Linux Mint 20.1

package: mongo-memory-server

What is the Problem?

in postinstall the relative path is preferred over the modulesCache path

Code Example

reproduction repository: https://github.com/seahindeniz/mongodb-memory-server-issue/tree/with-npm

Do you know why it happenes?

not yet

Found thanks to @seahindeniz in #464
@hasezoey hasezoey added the bug label Jun 1, 2021
@hasezoey hasezoey mentioned this issue Jun 1, 2021
Closed
@hasezoey hasezoey added the has repro script This issue has an reproduce script label Jun 1, 2021
hasezoey added a commit that referenced this issue Jun 2, 2021
@hasezoey
fix(DryMongoBinary): use "INIT_CWD" when available
cc2da32 
fixes #478
hasezoey added a commit that referenced this issue Jun 2, 2021
@hasezoey
fix(DryMongoBinary): only use global path when not empty
9d176b2 
fixes #478
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

🎉 This issue has been resolved in version 7.0.0-beta.43 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hasezoey
Copy link
Collaborator Author

closing because fixed in 7.0.0-beta.43

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has repro script This issue has an reproduce script released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hasezoey