Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: "instanceInfo" is undefined #501

Closed
Stono opened this issue Jul 6, 2021 · 3 comments · Fixed by #503
Closed

Error: "instanceInfo" is undefined #501

Stono opened this issue Jul 6, 2021 · 3 comments · Fixed by #503
Labels
bug released Pull Request released | Issue is fixed

Comments

@Stono
Copy link

Stono commented Jul 6, 2021

Hey,
Just updated to 7.1.0 and our tests started doing this:

  1) Mongo Store
       "before each" hook for "should create items":
     Error: "instanceInfo" is undefined
      at assertionInstanceInfo (node_modules/mongodb-memory-server-core/src/MongoMemoryServer.ts:725:2)
      at MongoMemoryServer.getUri (node_modules/mongodb-memory-server-core/src/MongoMemoryServer.ts:640:5)
      at Function.FromInMemory (lib/client.ts:75:30)
      at Context.<anonymous> (test/index.test.ts:29:14)

Turns out I could resolve the issue by explicitly calling .start(), which on 6.x.x we didn't have to do.

It's no biggie, but a change in behaviour I figure I'd share in case others were left confused by it. Might be good to perhaps instead error with "Please call .start() before .getUri()"?
@Stono Stono added the bug label Jul 6, 2021
@hasezoey
Copy link
Collaborator

hasezoey commented Jul 6, 2021

Duplicate of #497

@hasezoey hasezoey closed this as completed Jul 6, 2021
@Stono
Copy link
Author

Stono commented Jul 6, 2021

Sorry for the dupe :)

hasezoey added a commit that referenced this issue Jul 6, 2021
@hasezoey
feat(MongoMemoryServer): getUri: throw StateError instead of assertio…
2e632ab 
…nError

fixes #501
fixes #497
fixes #458
@hasezoey hasezoey mentioned this issue Jul 6, 2021
Merged
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

🎉 This issue has been resolved in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released Pull Request released | Issue is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup docs and errors nodkz/mongodb-memory-server
2 participants
@Stono @hasezoey