Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding mongodChildProcess.unref() #696

Closed
hasezoey opened this issue Sep 25, 2022 · 4 comments
Closed

Consider adding mongodChildProcess.unref() #696

hasezoey opened this issue Sep 25, 2022 · 4 comments
Labels
breaking This PR is a breaking change | This Issue to fix would be a breaking change feature released on @beta released Pull Request released | Issue is fixed
Milestone
9.0

Comments

@hasezoey
Copy link
Collaborator

Consider adding mongodChildProcess.unref(), this should make it possible for nodejs to exit even if the mongod process did not exit yet, this should be good for when no .stop is called or some tests terminate early and somehow dont call .stop
@hasezoey hasezoey added feature breaking This PR is a breaking change | This Issue to fix would be a breaking change labels Sep 25, 2022
@hasezoey hasezoey added this to the 9.0 milestone Sep 25, 2022
@hasezoey hasezoey changed the title Condier adding mongod.unref() Consider adding mongodChildProcess.unref() Sep 25, 2022
@meyfa
Copy link

meyfa commented Sep 26, 2022

This would be a very welcome change, indeed! We are currently struggling with unit tests not exiting, which is near impossible to debug. This change would either fix the problem or indicate that the problem lies elsewhere.

hasezoey added a commit that referenced this issue May 8, 2023
@hasezoey
fix(MongoInstance): change to call ".unref" on the mongodb process
59ec785 
fixes #696
@hasezoey
Copy link
Collaborator Author

hasezoey commented May 8, 2023

done with 59ec785

@hasezoey hasezoey closed this as completed May 8, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 9.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hasezoey
Copy link
Collaborator Author

hasezoey commented Oct 6, 2023

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Manual message because semantic-release hit the limit

@hasezoey hasezoey added the released Pull Request released | Issue is fixed label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This PR is a breaking change | This Issue to fix would be a breaking change feature released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Milestone
9.0
Development

No branches or pull requests
2 participants
@meyfa @hasezoey