Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Config option to overwrite the distro used #753

Closed
hasezoey opened this issue Mar 16, 2023 · 3 comments · May be fixed by DanneelsSophie/events#894
Closed

Add Config option to overwrite the distro used #753

hasezoey opened this issue Mar 16, 2023 · 3 comments · May be fixed by DanneelsSophie/events#894
Labels
feature released on @beta released Pull Request released | Issue is fixed

Comments

@hasezoey
Copy link
Collaborator

hasezoey commented Mar 16, 2023 •
edited

Currently there is no way to overwrite which distro is used as a config option, but there is for VERSION, ARCH and PLATFORM, and the only way to currently overwrite the distro is to use ARCHIVE_NAME, which effectively means to handle everything else (like ARCH and PLATFORM) manually.

as for implementation details:
this option effectively overwrites the distro in the final archive string, but PLATFORM will still be used to decide which path to take (windows, mac or linux), because PLATFORM is meant to overwrite os.platform
hasezoey added a commit that referenced this issue Jun 9, 2023
@hasezoey
feat(MongoBinaryDownloadUrl): add ability to overwrite distro used
f2b1c62 
fixes #753
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

🎉 This issue has been resolved in version 8.14.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 8.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Aug 15, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 9.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DanneelsSophie DanneelsSophie mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade mongodb-memory-server from 8.11.3 to 8.16.0 DanneelsSophie/events
1 participant
@hasezoey